Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove async library #2514

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: remove async library #2514

merged 2 commits into from
Jan 30, 2023

Conversation

mpetrunic
Copy link
Contributor

No description provided.

@mpetrunic mpetrunic mentioned this pull request Jan 30, 2023
Closed
31 tasks
@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Merging #2514 (0b29a44) into master (02ec892) will increase coverage by 1.25%.
The diff coverage is 65.62%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.10% <ø> (?)
blockchain 90.02% <ø> (?)
client 87.59% <ø> (ø)
common 95.82% <ø> (?)
devp2p 91.62% <ø> (?)
ethash ∅ <ø> (∅)
evm 83.35% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.61% <ø> (?)
trie 90.36% <ø> (?)
tx 93.71% <ø> (ø)
util 84.48% <65.62%> (?)
vm 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

g11tech
g11tech approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

gabrocheleau
gabrocheleau approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Always nice to remove deps, can be merged once tests pass

@acolytec3 acolytec3 merged commit ff921f8 into ethereumjs:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@gabrocheleau gabrocheleau gabrocheleau approved these changes

Assignees
No one assigned
Labels
package: util PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mpetrunic @gabrocheleau @g11tech @holgerd77 @acolytec3