Monorepo Wallet Library Integration #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason is KryptoKit requires 'aesjs', which adds extra 70k of code when browserified. This change could be reverted once the code can be replaced with 'crypto'.
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
added
PR state: needs review
PR state: do-not-merge
and removed
PR state: WIP
labels
This was referenced May 26, 2023
acolytec3
approved these changes
May 26, 2023
| @@ -0,0 +1,36 @@ | |||
| name: Build | |||
There was a problem hiding this comment.
Shouldn't this workflow move into our monorepo, instead of reside into packages/wallet?
|
Ok it seems like our CI does not run the wallet build CI, we should add. |
|
Nvm thats part of #2731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the ethereumj-wallet library into the monorepo, creating a dedicated folder
packages/walletwith the corresponding source and other files.ATTENTION!!!
THIS NEEDS TO BE MERGED WITH A MERGE COMMIT!!!
DO NOT SQUASH!!!!!
Integration follows the path from e.g. #971, so creating a branch on the original repository, move all files there to the
packages/walletfolder already and then add the wallet repository locally to the monorepo as a Git remote and merge the wallet branch to a monorepo branch (so, this one:monorepo-add-wallet) with the flag--allow-unrelated-histories.So one main goal with the procedure is to preserve the git commit history, this has been proven to work various times already though. For this round I have also tested this locally.
WIP, this needs some various adoptions still.