Remove devnet6 trusted setup #3288
Conversation
There was a problem hiding this comment.
Note, I removed the nethermind blob transaction in the tx eip4844 tests because it was created on devnet6 and I have no way of regnerating that test data using the mainnet trusted setup. I will try and find a full blob transaction from geth or another client that we can verify using the new settings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -119,7 +119,7 @@ describe(method, () => { | |||
| const { executionPayload, blobsBundle } = res.result | |||
| assert.equal( | |||
| executionPayload.blockHash, | |||
| '0xe8175305416ee94c996164162044338b4f4d93a8dc458b574ecad4ce84323fb5', | |||
| '0x8c71ad199a3dda94de6a1c31cc50a26b1f03a8a4924e9ea3fd7420c6411cac42', | |||
There was a problem hiding this comment.
I am fine with this change, however, how do we know this is correct?
| @@ -600,31 +598,6 @@ describe('Network wrapper deserialization test', () => { | |||
| }, | |||
| 'txMeta should match' | |||
| ) | |||
|
|
|||
| // override common chain id and test nethermind generated tx | |||
| common.chainId = () => BigInt(42) | |||
There was a problem hiding this comment.
This is the removed one?
Okay, I basically just updated the expected outputs to match what is produced when you use the official trusted setup instead of the devnet 6 one. |
|
Updated this via UI |
Updates all references to the
devnet6.txttrusted setup to point to theofficial.txttrusted setup for mainnet.Also regenerates test data where necessary using official trusted setup.