EIP 6110 fixes

[jochem-brouwer]

This PR runs these 6110 tests: https://github.com/ethereum/execution-spec-tests/files/15101579/fixtures_develop.tar.gz

(only activate 6110 and 7685 in common)

[jochem-brouwer]

Current status

Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-multiple_deposit_from_same_eoa]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0xb164f1922a21bcba751e0e045289fb784fc8df9f650324e9df157c76c0434116 hf=prague baseFeePerGas=7 txs=2 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-multiple_deposit_from_same_eoa_high_count]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0x988b9317a6aafeb5b8a25953d92b2fe13ab5ecb6d92dafbde00b6748302e8420 hf=prague baseFeePerGas=7 txs=2000 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-multiple_deposit_from_different_eoa]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0xe0ee0395258646d91291a46d8e9dceeed0e853ac08ed405732d00c461c3f8915 hf=prague baseFeePerGas=7 txs=2 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-multiple_deposits_from_contract]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0xeea5d13534f4d682df4d68301d294fd3b933cd5ab5659a9e09b548e980acaab7 hf=prague baseFeePerGas=7 txs=1 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-single_deposit_from_contract_single_deposit_from_eoa]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0x07f457eb1e9945427d805f2bf0a84a588a54ee62eaf3b3a2de3c774b12fb74b8 hf=prague baseFeePerGas=7 txs=2 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-single_deposit_from_eoa_single_deposit_from_contract]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0xba8e98a070716ca39d126e461b8fccd33e85ed832031c10fc7e0ced4a572fa8c hf=prague baseFeePerGas=7 txs=2 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-single_deposit_from_contract_between_eoa_deposits]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0xce8509e9a42a7eb48b60d102432cfadf799c0301a6dfa1d8b8bd978395a418a5 hf=prague baseFeePerGas=7 txs=3 uncles=0)
	correct last header block
Errors thrown in file: blockchain_tests/prague/eip6110_deposits/deposits/deposit.json test: tests/prague/eip6110_deposits/test_deposits.py::test_deposit[fork_Prague-blockchain_test-single_deposit_from_eoa_between_contract_deposits]:
	Error: invalid requestsRoot (vm hf=prague -> block number=1 hash=0x724b96fc1df1a0699be602f35048bdf8977bd34c1d770312a2f0495e9dc3c856 hf=prague baseFeePerGas=7 txs=3 uncles=0)
	correct last header block

[acolytec3]

That's a promising start!

[acolytec3]

I wonder if we're not encoding the other 3 fields correctly (e.g. they're BE in the event but should be LE in the request)?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.25%. Comparing base (61acbd3) to head (b50183d).
Report is 18 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
tx	?
wallet	87.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[jochem-brouwer]

I just fixed it, all tests now pass! For some reason extracting LE Uint64 using DataView did not work, so I settled on this by manually converting the LEs to BEs.

[acolytec3]

Just need to adjust the error message the test checks for and this will be ready to merge

[acolytec3]

LGTM

[scorbajio]

LGTM