Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util,block,client,evm,vm: add EIP 7251 el triggered consolidations request type #3477

Merged
merged 5 commits into from
Jun 29, 2024
Merged

util,block,client,evm,vm: add EIP 7251 el triggered consolidations request type #3477

merged 5 commits into from
Jun 29, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 29, 2024 •
edited
Loading

add devnet 1 spec consolidations
for devnet 1 of prague (spec: https://notes.ethereum.org/@ethpandaops/pectra-devnet-1)

ref

TODO:

  • fix failing spec
  • modify newPayloadV4 spec

acolytec3
acolytec3 requested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine though though a bit more comments in the couple of places I highlighted would be helpful

packages/client/src/rpc/validation.ts Outdated Show resolved Hide resolved
packages/client/test/rpc/engine/newPayloadV4.spec.ts
'0x00b42dbF2194e931E80326D950320f7d9Dbeac02': {
balance: '0',
nonce: '1',
code: '0x3373fffffffffffffffffffffffffffffffffffffffe146098573615156028575f545f5260205ff35b36606014156101445760115f54600182026001905f5b5f82111560595781019083028483029004916001019190603e565b90939004341061014457600154600101600155600354806004026004013381556001015f35815560010160203581556001016040359055600101600355005b6003546002548082038060011160ac575060015b5f5b81811460f15780607402838201600402600401805490600101805490600101805490600101549260601b84529083601401528260340152906054015260010160ae565b9101809214610103579060025561010e565b90505f6002555f6003555b5f548061049d141561011d57505f5b6001546001828201116101325750505f610138565b01600190035b5f555f6001556074025ff35b5f5ffd',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the code for this new system contract to perform consolidations? Can we provide some minimal commentary on how it works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its fully explained in EIP in detail

acolytec3
acolytec3 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.60000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (d24ca11) to head (3589f57).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 80.24% <35.29%> (?)
blockchain 90.97% <ø> (ø)
client 84.30% <38.80%> (?)
common 94.42% <100.00%> (+0.13%) ⬆️
devp2p 81.83% <ø> (?)
evm 73.75% <100.00%> (?)
genesis 99.98% <ø> (?)
statemanager 74.81% <ø> (+0.51%) ⬆️
trie 60.63% <ø> (?)
tx 85.93% <ø> (?)
util 81.46% <ø> (+0.03%) ⬆️
vm 63.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech merged commit e31a65b into master Jun 29, 2024
33 of 36 checks passed
@holgerd77 holgerd77 deleted the add-consolidation branch July 1, 2024 06:15
@holgerd77
Copy link
Member

Ugh, we are getting new EIPs added to the code base really quickly 🤯.

Had a quick glance and seems everything ok, but we really shouldn't go quicker than this. 🙂

HARD RULE: NO MORE THAN ONE EIP PER HOUR!!! 😂 😂 😂

This was referenced Sep 5, 2024
Open
Open
Open
Open
This was referenced Sep 12, 2024
Merged
Merged
This was referenced Sep 18, 2024
Open
Open
Open
Open
@CASABECI CASABECI mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: block package: client package: evm package: util package: vm PR state: merge ready type: spec updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @holgerd77 @acolytec3