Fix statemanager empty code bug #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-approve and merge? 😄 |
|
There are still so many commits shown in this PR, is this normal? 🤔 |
|
Shouldn't these go away once the base changes? |
|
Ok, I'll do it. Should hopefully be ok, changes shown also only show the small diff set. |
|
Sorry, missed those comments. Squash and merge should do it in the end right? Maybe when I merged 7702 into this one it might have messed up the git commit history 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in StateManager where empty code is put on an account which already has code. This did not
modifyAccountFieldsbefore, which invalidates the cache.Note: built on top of 7702 see #3470.