Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure EthJS and Grandine talk #3511

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Ensure EthJS and Grandine talk #3511

merged 2 commits into from
Jul 17, 2024

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Jul 17, 2024 •
edited
Loading

Closes #3508

It seems we changed jwt-simple internally. jwt-simple is now edited (internally) to support decoding/encoding unpadded payload bytes.

This fixes CL <-> EL communication with Grandine. I also tested this (before and after) on Prysm, and the communication works.

@jochem-brouwer jochem-brouwer merged commit 41931d6 into master Jul 17, 2024
34 checks passed
@jochem-brouwer jochem-brouwer deleted the fix-grandine-ethjs-comms branch July 17, 2024 11:16
@jochem-brouwer jochem-brouwer mentioned this pull request Jul 17, 2024
Closed
@jochem-brouwer jochem-brouwer mentioned this pull request Aug 14, 2024
Merged
holgerd77 pushed a commit that referenced this pull request Aug 15, 2024
@jochem-brouwer @holgerd77
Ensure EthJS and Grandine talk (#3511)
5ce4668 
* jwt-simple: ensure unpadded payloads are accepted

* jwt-simple: ensure encoded jwts are also unpadded
holgerd77 added a commit that referenced this pull request Aug 15, 2024
@holgerd77 @jochem-brouwer
@acolytec3 @gabrocheleau
New Minor Releases (Prague Outlook, Bundle Fixes, Bugfixes) (#3527)
27e2c02 
* Update to the correct release date for the old releases

* Add new release date in CHANGELOG files

* CHANGELOG entries for Kaustinen5 PR, Util partial account CHANGELOG, docs and example

* PrefixedHexString PR CHANGELOG integration

* Add EIP-6110/EIP-7002/EIP-7685 related release notes, documentation updates and examples

* Additional EIP-6110/EIP-7002 README inclusions, EIP table updates

* Add EIP-2935 BLS precompile release notes and a new EVM precompile doc setion and example

* Add EOACodeEIP7702Tx example, README section and CHANGELOG entry

* Additional EIP-7702 CHANGELOG and README additions

* More 7702

* Small additions and some fixes for BLS CHANGELOG entries

* Verkle related CHANGELOG additions

* Various CHANGELOG additions

* Add EIP-7251 consoldiation requests block example and extensive README section, Util CHANGELOG/README for the new class and other CHANGELOG/README additions

* Add proper EIP-2935 (Serve historical block hashes from state) release notes

* Adjust EIP-2935/7709 release notes, add EIP-7610 (state-related retroactive EIP) release notes

* Additional release notes

* Version bumps (Util)

* Version bumps (Common)

* Version bumps (Trie)

* Version bumps (Verkle)

* Version bumps (Tx)

* Version bumps (Wallet)

* Version bumps (Genesis)

* Version bumps (Devp2p)

* Version bumps (Ethash)

* Version bumps (Block)

* Version bumps (Blockchain)

* Version bumps (StateManager)

* Version bumps (EVM)

* Version bumps (VM, client)

* Rebuild package-lock.json

* Update release dates in CHANGELOG files

* Fix typos and URLs

* Minor nits

* Update packages/block/CHANGELOG.md

* Update packages/block/CHANGELOG.md

* More consistent and improved EIP-7685 Requests docs/CHANGELOGs

* Ensure EthJS and Grandine talk (#3511)

* jwt-simple: ensure unpadded payloads are accepted

* jwt-simple: ensure encoded jwts are also unpadded

* Make 7702 outdated status more clear

* 2935 fix

* Small fixes

---------

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
holgerd77 added a commit that referenced this pull request Aug 15, 2024
@holgerd77 @jochem-brouwer
@acolytec3 @gabrocheleau
New Minor Releases (Prague Outlook, Bundle Fixes, Bugfixes) (#3527)
d10e712 
* Update to the correct release date for the old releases

* Add new release date in CHANGELOG files

* CHANGELOG entries for Kaustinen5 PR, Util partial account CHANGELOG, docs and example

* PrefixedHexString PR CHANGELOG integration

* Add EIP-6110/EIP-7002/EIP-7685 related release notes, documentation updates and examples

* Additional EIP-6110/EIP-7002 README inclusions, EIP table updates

* Add EIP-2935 BLS precompile release notes and a new EVM precompile doc setion and example

* Add EOACodeEIP7702Tx example, README section and CHANGELOG entry

* Additional EIP-7702 CHANGELOG and README additions

* More 7702

* Small additions and some fixes for BLS CHANGELOG entries

* Verkle related CHANGELOG additions

* Various CHANGELOG additions

* Add EIP-7251 consoldiation requests block example and extensive README section, Util CHANGELOG/README for the new class and other CHANGELOG/README additions

* Add proper EIP-2935 (Serve historical block hashes from state) release notes

* Adjust EIP-2935/7709 release notes, add EIP-7610 (state-related retroactive EIP) release notes

* Additional release notes

* Version bumps (Util)

* Version bumps (Common)

* Version bumps (Trie)

* Version bumps (Verkle)

* Version bumps (Tx)

* Version bumps (Wallet)

* Version bumps (Genesis)

* Version bumps (Devp2p)

* Version bumps (Ethash)

* Version bumps (Block)

* Version bumps (Blockchain)

* Version bumps (StateManager)

* Version bumps (EVM)

* Version bumps (VM, client)

* Rebuild package-lock.json

* Update release dates in CHANGELOG files

* Fix typos and URLs

* Minor nits

* Update packages/block/CHANGELOG.md

* Update packages/block/CHANGELOG.md

* More consistent and improved EIP-7685 Requests docs/CHANGELOGs

* Ensure EthJS and Grandine talk (#3511)

* jwt-simple: ensure unpadded payloads are accepted

* jwt-simple: ensure encoded jwts are also unpadded

* Make 7702 outdated status more clear

* 2935 fix

* Small fixes

---------

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
holgerd77 added a commit that referenced this pull request Aug 15, 2024
@holgerd77 @jochem-brouwer
@acolytec3 @gabrocheleau
Minor Release PR master Branch Port (#3594)
81ef495 
* New Minor Releases (Prague Outlook, Bundle Fixes, Bugfixes) (#3527)

* Update to the correct release date for the old releases

* Add new release date in CHANGELOG files

* CHANGELOG entries for Kaustinen5 PR, Util partial account CHANGELOG, docs and example

* PrefixedHexString PR CHANGELOG integration

* Add EIP-6110/EIP-7002/EIP-7685 related release notes, documentation updates and examples

* Additional EIP-6110/EIP-7002 README inclusions, EIP table updates

* Add EIP-2935 BLS precompile release notes and a new EVM precompile doc setion and example

* Add EOACodeEIP7702Tx example, README section and CHANGELOG entry

* Additional EIP-7702 CHANGELOG and README additions

* More 7702

* Small additions and some fixes for BLS CHANGELOG entries

* Verkle related CHANGELOG additions

* Various CHANGELOG additions

* Add EIP-7251 consoldiation requests block example and extensive README section, Util CHANGELOG/README for the new class and other CHANGELOG/README additions

* Add proper EIP-2935 (Serve historical block hashes from state) release notes

* Adjust EIP-2935/7709 release notes, add EIP-7610 (state-related retroactive EIP) release notes

* Additional release notes

* Version bumps (Util)

* Version bumps (Common)

* Version bumps (Trie)

* Version bumps (Verkle)

* Version bumps (Tx)

* Version bumps (Wallet)

* Version bumps (Genesis)

* Version bumps (Devp2p)

* Version bumps (Ethash)

* Version bumps (Block)

* Version bumps (Blockchain)

* Version bumps (StateManager)

* Version bumps (EVM)

* Version bumps (VM, client)

* Rebuild package-lock.json

* Update release dates in CHANGELOG files

* Fix typos and URLs

* Minor nits

* Update packages/block/CHANGELOG.md

* Update packages/block/CHANGELOG.md

* More consistent and improved EIP-7685 Requests docs/CHANGELOGs

* Ensure EthJS and Grandine talk (#3511)

* jwt-simple: ensure unpadded payloads are accepted

* jwt-simple: ensure encoded jwts are also unpadded

* Make 7702 outdated status more clear

* 2935 fix

* Small fixes

---------

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>

* Lint fix

* Add generic examples:build script in root package.json

* Fixes

* EVM example fix

* shorten stupid decode-opcodes example

---------

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrocheleau gabrocheleau gabrocheleau approved these changes

Assignees
No one assigned
Labels
package: client PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overly strict JWT decoding?
2 participants
@jochem-brouwer @gabrocheleau