Remove almost all cspell:ignore
#3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
added a commit
that referenced
this pull request
Aug 17, 2024
* monorepo: add cspell, add ALL unknown words to valid words * cspell: split unknown words in ts/md * filter out wrong words in cspell-ts.json * cspell ignore hex values * fix typos in all packages * cspell: use cache * cspell: update commands * cspell: update md/ts words * Typo fixes for README/CHANGELOG files * cspell: ensure all relevant monorepo md files are checked * ci: add cspell job * cspell: update command * temp add bogus to markdown * remove bogus spell * update ci name * fix remaining typos + add words to cspell dict * Update packages/client/CHANGELOG.md * Update packages/util/CHANGELOG.md * address review * Remove almost all `cspell:ignore` (#3599) * remove almost all cspell:ignore * more spell changes * cspell: fix problems * evm: fix quadCoefficient * cspell: fixes * remove disable line --------- Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
holgerd77
pushed a commit
that referenced
this pull request
Aug 19, 2024
* monorepo: add cspell, add ALL unknown words to valid words * cspell: split unknown words in ts/md * filter out wrong words in cspell-ts.json * cspell ignore hex values * fix typos in all packages * cspell: use cache * cspell: update commands * cspell: update md/ts words * Typo fixes for README/CHANGELOG files * cspell: ensure all relevant monorepo md files are checked * ci: add cspell job * cspell: update command * temp add bogus to markdown * remove bogus spell * update ci name * fix remaining typos + add words to cspell dict * Update packages/client/CHANGELOG.md * Update packages/util/CHANGELOG.md * address review * Remove almost all `cspell:ignore` (#3599) * remove almost all cspell:ignore * more spell changes * cspell: fix problems * evm: fix quadCoefficient * cspell: fixes * remove disable line --------- Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
holgerd77
reviewed
Aug 19, 2024
| @@ -8,7 +8,7 @@ | |||
| "checkNpmVersion": "./scripts/check-npm-version.sh", | |||
| "clean": "./config/cli/clean-root.sh", | |||
| "cspell": "npm run cspell:ts && npm run cspell:md", | |||
| "cspell:ts": "npx cspell --gitignore -e \"./packages/ethereum-tests\" -e \"./packages/wallet/test\" -c ./config/cspell-ts.json \"./packages/**/*.ts\" --cache --show-suggestions --show-context", | |||
| "cspell:ts": "npx cspell --gitignore -e \"./packages/ethereum-tests\" -e \"./packages/wallet/test\" -e \"./packages/client/archive\" -c ./config/cspell-ts.json \"./packages/**/*.ts\" --cache --show-suggestions --show-context", | |||
There was a problem hiding this comment.
Nit: can't more of these options put in the configuration file so that we can keep it simpler here?
holgerd77
added a commit
that referenced
this pull request
Aug 19, 2024
…Code put() Fix, VerkleSM out, runTx()+Code Opts) (#3601) * Use shallowCopy() Caches copy() optimization also for VerkleSM to avoid Caches bundling on non-Caches default * Fix default state manager missing direct code write when used without caches * Do not initialize caches for default VM state manager * Remove copy test not making sense any more under generalized cache/no-cache conditions * Some more solid/qualified EVM dummy blockchain + interface naming to allow for exporting * Use EVMMockBlockchain(Interface) as default for the VM, adjust some tests * Move @ethereumjs/blockchain to dev dependencies in VM * Rebuild package-lock.json * Adjust/fix some client tests * Lint fix * Add Verkle SM methods as optional methods to interface, replace VerkleSM imports and castings in VM * Also align client (no real effect yet, but generally try to work more on the interfaces and not the classes directly) * Initialize runTx() default block with simpler constructor to avoid drawing all txs in * Fully switch to DEFAULT_HEADER in VM.runTx() to avoid drawing in block code * Opcode list size optimization * More optimizations * Precompile code optimizations * More optimizations (precompile index.ts file) * Some more * Some doc compatification * Add CSpell checker to CI and fix typos (#3590) * monorepo: add cspell, add ALL unknown words to valid words * cspell: split unknown words in ts/md * filter out wrong words in cspell-ts.json * cspell ignore hex values * fix typos in all packages * cspell: use cache * cspell: update commands * cspell: update md/ts words * Typo fixes for README/CHANGELOG files * cspell: ensure all relevant monorepo md files are checked * ci: add cspell job * cspell: update command * temp add bogus to markdown * remove bogus spell * update ci name * fix remaining typos + add words to cspell dict * Update packages/client/CHANGELOG.md * Update packages/util/CHANGELOG.md * address review * Remove almost all `cspell:ignore` (#3599) * remove almost all cspell:ignore * more spell changes * cspell: fix problems * evm: fix quadCoefficient * cspell: fixes * remove disable line --------- Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com> * Fix spell check * Remove accidentally committed examples/test.ts file --------- Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com> Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes almost all
cspell:ignoreon top of script files.Notes:
./packages/client/archivefor cspell. Once we reuse it, it will automatically get into the spell check poolcspell:ignorein wallet, because I don't know what those values mean, and I don't want to touch the wallet codeTODO
// cspellcomments into the docs of methods/classes, this will thus also end up in the end doc. Need to figure out how to fix this, since wrapping the entire comment incspell:disablean thencspell:enablewill effectively disable the spell check for those docs which is not what we want.