Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: refactor trie and verkle utils #3600

Merged
merged 4 commits into from
Aug 17, 2024
Merged

utils: refactor trie and verkle utils #3600

merged 4 commits into from
Aug 17, 2024

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Aug 16, 2024 •
edited
Loading

This PR:

  • Refactors the bytes utils from the verkle package into the utils package
  • Refactors the PrioritizedTaskExecutor from the trie and verkle packages into the utils package, eliminating the need for duplicated code

@gabrocheleau gabrocheleau changed the title verkle: remove bytes utils verkle: refactor utils Aug 16, 2024
@gabrocheleau gabrocheleau marked this pull request as ready for review August 16, 2024 21:19
@gabrocheleau gabrocheleau changed the title verkle: refactor utils utils: refactor trie and verkle utils Aug 16, 2024
holgerd77
holgerd77 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Nice! 🙂

LGTM

@holgerd77 holgerd77 merged commit 0aa7445 into master Aug 17, 2024
34 checks passed
@holgerd77 holgerd77 deleted the verkle/refactor-utils branch August 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: mpt package: util package: verkle type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @holgerd77