Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging consistent #3654

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Make logging consistent #3654

merged 4 commits into from
Sep 11, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Sep 11, 2024

This change checks for the ethjs rail guard to be active for logging to be activated in the client, devp2p, statemanager, and blockchain packages. This makes them consistent with the rest of the packages that abide by the guard rail, as discussed in #3634.

In order to test this, one can try running DEBUG='ethjs,*' npm run client:start:dev2 and comparing it's log output to running DEBUG='*' npm run client:start:dev2.

In a followup PR, the documentation of the monorepo packages that support logging will be updated with logging instructions/details.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 1.88679% with 52 lines in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (4470cc3) to head (d3d159c).
Report is 50 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 71.56% <ø> (-1.89%) ⬇️
blockchain 89.28% <ø> (?)
client ?
common 91.47% <ø> (?)
devp2p 0.00% <0.00%> (?)
genesis 0.00% <ø> (?)
statemanager 70.06% <4.34%> (?)
trie 54.51% <ø> (?)
tx ?
util 75.53% <ø> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scorbajio scorbajio merged commit 0041c53 into master Sep 11, 2024
39 of 40 checks passed
@scorbajio scorbajio deleted the make-logging-consistent branch September 11, 2024 03:28
@holgerd77
Copy link
Member

Also massive! 🤩😎👍

Side note: didn’t even think about client, but this is actually a good preparation for the library-fication of the client! 🙏🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants