Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ethereum-cryptography / Remove Direct EVM @noble/curves Usage #3668

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

ScottyPoi
Copy link
Contributor

Issue: #3664 -

All Packages:
Upgrades to ethereum-cryptography v3 (3.0.0)

  • Wallet: Removes await from non-Promise encrypt and decrypt functions

@ScottyPoi ScottyPoi added PR state: needs review package: monorepo dependencies Pull requests that update a dependency file target: master Work to be done towards master branch labels Sep 13, 2024
@holgerd77
Copy link
Member

Ok, just wanted to test if deduplication of @noble/curves for the EVM works (there we have the direct dependency, and then we also have the one from ethereum-cryptography).

So this is master (with @noble/curves being double-present upper-right and lower-left, recognisable e.g. from the weierstrass.js inclusion):

grafik

And this is the PR:

grafik

Works! 🎉

Another 80 KB chopped off!

@holgerd77
Copy link
Member

Update: ah, just seeing this, I guess we can use bls and bn directly from ethereum-cryptography - since it is exposed there (Paul also somewhat mentioned in the issue), then we can skip this direct @noble/curves dependency alltogether and do not run the risk of re-duplicating again by versions moving apart.

Will directly test (and merge) this in the realm of this PR.

@holgerd77 holgerd77 changed the title Upgrade ethereum-cryptography Upgrade ethereum-cryptography / Remove Direct EVM @noble/curves Usage Sep 16, 2024
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, works 🙂, will take this in!

@holgerd77 holgerd77 merged commit 47f388b into master Sep 16, 2024
39 checks passed
@holgerd77 holgerd77 deleted the upgrade-ethereum-cryptography branch September 16, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: monorepo PR state: needs review target: master Work to be done towards master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants