Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 support #3669

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Node 22 support #3669

merged 3 commits into from
Sep 16, 2024

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Sep 13, 2024

Linked issue: #3644

  1. "node-versions" workflow did not change versions
  • Both v18 and v20 tests used v20
  • This was fixed, and tests now run (and pass) using correct version
  1. Added v22 to the list of versions tested in "node-versions"
  • Ran workflow manually to confirm passing

@jochem-brouwer
Copy link
Member

This adds node 22 to nightly tests - right?

fail-fast: false
steps:
- uses: actions/checkout@v4
with:
submodules: recursive

- name: Use Node.js 20
- name: Use Node.js ${{ matrix.node-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️🤦‍♂️🤦‍♂️

We professionals. 😂

@holgerd77 holgerd77 changed the title (WIP) node 22 support Node 22 support Sep 16, 2024
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bear with me, I’ve now updated the title and merged, hope that’s ok but didn’t see further work to be done?

Thanks for the PR! 👍🙂

@holgerd77 holgerd77 merged commit b763c47 into master Sep 16, 2024
39 checks passed
@holgerd77 holgerd77 deleted the node-version-22 branch September 16, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants