Debug logger namespace standardization #3692
Open
+88
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in wild-card namespaces
scorbajio
force-pushed
the
debug-namespace-standardization
branch
from
215484a
to
7b23b79
Compare
|
The logger namespaces are now using lowercase tags. trie: verkle: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| const canonicalHeadHash = (await this.getCanonicalHeadHeader()).hash() | ||
| let canonicalHeadHash: Uint8Array | undefined | ||
| if (this.DEBUG) { | ||
| canonicalHeadHash = (await this.getCanonicalHeadHeader()).hash() |
There was a problem hiding this comment.
Ah nice find that this is only necessary when in debug mode 😄
| @@ -352,7 +355,7 @@ export class Blockchain implements BlockchainInterface { | |||
|
|
|||
| this.DEBUG && | |||
| this._debug( | |||
| `Canonical head set from ${bytesToHex(canonicalHeadHash)} to ${bytesToHex(hash!)} (number ${bigIntToHex(canonicalHead)})`, | |||
| `Canonical head set from ${canonicalHeadHash ? bytesToHex(canonicalHeadHash) : 'unknown'} to ${bytesToHex(hash!)} (number ${bigIntToHex(canonicalHead)})`, | |||
There was a problem hiding this comment.
Since this.DEBUG is true in this case, we know canonicalHeadHash is set, so the ? : logic should be deleted here (if TypeScript complains, we know canonicalHeadHash is set so you can make TS know it is set by using canonicalHeadHash! (add exclamation mark))
| | `verkle:*` | verbose debug logging for all verkle methods | | ||
| | Logger | Description | | ||
| | ------------------- | ------------------------------------ | | ||
| | `verkle:put` | a verkle put operation has occurred | |
There was a problem hiding this comment.
There should be an addition for verkle:# here.
| @@ -466,7 +466,7 @@ The following options are available: | |||
|
|
|||
| | Logger | Description | | |||
| | ------------------- | ------------------------------------------------ | | |||
| | `client:fetcher` | This option enables logging for all fetchers | | |||
| | `client:fetcher:#` | This option enables logging for all fetchers | | |||
There was a problem hiding this comment.
I don't see any changes in the client code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the issues raised in #3689.