-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further troubleshoot current codecov CI issues #3751
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
I just checked all of the packages (devp2p, wallet, genesis, client) that are showing no coverage in codecov, and it seems like their lcov files are being uploaded, but since their coverage difference is being calculated from the lcov files uploaded from the last commit on |
In order to update codecov coverage, we'd need to merge this in order for coverage to be calculated and uploaded for the |
🙏 Cool! Can you maybe extract the TODO list from above in a separate issue, at least if you plan to do this several iterations (likely, right?). Otherwise this will create this weird referencing of this sub-PR, that will likely get confusing at some point. But - yeah - totally like respectively feels good that we get a coverage re-integration! 😆 🤩 |
This change is a followup on #3376 and looks into remaining codecov issues:
rlp
andethash
packages are uploading coverage reports, but their reports are erroring out as unusable. I remember working on this before and opening a codecov ticket on it too (in the codecov official repo) that didn't get much activity, but will look into and followup on this on as well.