Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further troubleshoot current codecov CI issues #3751

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Oct 17, 2024

This change is a followup on #3376 and looks into remaining codecov issues:

  • The master branch isn't having coverage pushed/calculated/visualized, so I'll see if this is just a misconfig or something
  • Some packages (devp2p, wallet, genesis, client) aren't having their coverage files uploaded? Or, atleast they're not showing up on codecov at the moment, so I'll triage and followup here.
  • As mentions by @jochem-brouwer, most of the coverage diffs seem to not be calculates/reported ( Troubleshoot codecov failures to upload coverage data #3376 (comment)).
  • rlp and ethash packages are uploading coverage reports, but their reports are erroring out as unusable. I remember working on this before and opening a codecov ticket on it too (in the codecov official repo) that didn't get much activity, but will look into and followup on this on as well.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.46%. Comparing base (4470cc3) to head (e7402fb).
Report is 102 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 67.57% <ø> (-5.89%) ⬇️
blockchain 83.49% <ø> (?)
client 0.00% <ø> (ø)
common 89.85% <ø> (?)
devp2p 0.00% <ø> (?)
evm 65.18% <ø> (?)
genesis 0.00% <ø> (?)
mpt 52.09% <ø> (?)
statemanager 67.41% <ø> (?)
tx 76.70% <ø> (-1.08%) ⬇️
util 71.23% <ø> (?)
vm 58.28% <ø> (?)
wallet 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scorbajio
Copy link
Contributor Author

I just checked all of the packages (devp2p, wallet, genesis, client) that are showing no coverage in codecov, and it seems like their lcov files are being uploaded, but since their coverage difference is being calculated from the lcov files uploaded from the last commit on master that had any uploads at all, the diffs aren't going to be calculated as expected. It may help to resolve the issue that's keeping master from having it's coverage updated in codecov to see if this fixes things here too.

@scorbajio
Copy link
Contributor Author

scorbajio commented Oct 17, 2024

In order to update codecov coverage, we'd need to merge this in order for coverage to be calculated and uploaded for the master branch. We may discover that this also solved other issues resulting from missing coverage from the master branch (which is used as the base for calculating coverage differences between commits), if not, I'll open up a different PR to address them.

@acolytec3 acolytec3 merged commit ac1c224 into master Oct 17, 2024
41 checks passed
@acolytec3 acolytec3 deleted the codecov-troubleshooting-followup branch October 17, 2024 20:32
@holgerd77
Copy link
Member

🙏

Cool! Can you maybe extract the TODO list from above in a separate issue, at least if you plan to do this several iterations (likely, right?). Otherwise this will create this weird referencing of this sub-PR, that will likely get confusing at some point.

But - yeah - totally like respectively feels good that we get a coverage re-integration! 😆 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants