Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement admin_addPeer #3788

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Implement admin_addPeer #3788

merged 8 commits into from
Nov 6, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Nov 5, 2024

This change provides an implementation for admin_addPeer as a part of the work being done in #3781 in order to integrate, develop, and provide an ethereumjs repl console. This work also relates to #1114 and increasing JSON-RPC API coverage.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Project coverage is 48.92%. Comparing base (974a5f4) to head (3d70841).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 0.00% <0.00%> (ø)
common 89.89% <ø> (ø)
devp2p 71.84% <ø> (-0.11%) ⬇️
evm 64.89% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.12% <ø> (+0.03%) ⬆️
statemanager 68.86% <ø> (ø)
tx 76.70% <ø> (ø)
util 72.78% <ø> (ø)
vm 57.37% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scorbajio scorbajio merged commit e38dccc into master Nov 6, 2024
40 of 41 checks passed
@scorbajio scorbajio deleted the admin-addPeer-rpc-implementation branch November 6, 2024 01:02
@holgerd77
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants