Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package level lint:fix back #3799

Merged
merged 8 commits into from
Nov 17, 2024
Merged

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Nov 16, 2024

By request, this re-introduces package level lint and lint:fix npm scripts. These will not run under normal circumstances but can be used to do package level linting.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.84%. Comparing base (65ab90c) to head (54e0348).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 74.00% <ø> (ø)
common 89.89% <ø> (ø)
devp2p 71.95% <ø> (+0.10%) ⬆️
evm 64.93% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.34% <ø> (+0.21%) ⬆️
rlp 95.11% <ø> (ø)
statemanager 68.84% <ø> (ø)
tx 76.52% <ø> (ø)
util 72.81% <ø> (ø)
vm 57.30% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 previously approved these changes Nov 16, 2024
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77
Copy link
Member

Ah, lint Check actually failing.

Also: is it then also possible to have the non-fix command available on package level as well?

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit e86eace into master Nov 17, 2024
41 checks passed
@holgerd77 holgerd77 deleted the bring-back-package-level-lint-fix branch November 17, 2024 09:50
@jochem-brouwer
Copy link
Member

Great, thanks! 🙏 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants