Pass the Common object when copying a StateManager

[alcuadrado]

Previous to this PR copying a StateManager always returned one with a Common object set to mainnet and byzantium (see #524). Now the Common object is passed when copying a StateManager.

[coveralls]

Coverage increased (+0.06%) to 95.006% when pulling 5c06175 on pass-common-statemanager-copy into 2e2e509 on master.

[holgerd77]

@s1na @alcuadrado I think we should give this (the v4 release) one week more - even for the beta release - to have some more time to play around, have a broader look, fix things in docs and examples, give folks from the community some chance to stop by and have a first look and maybe also discover things.

What do you guys think? Just had some first look at the merged repo and I think this should really settle a bit more...

[holgerd77]

(@alcuadrado sorry for hi-jacking here 😛, thought there should be some space left due to not much need for discussion on the PR topic 😋)

[holgerd77]

@alcuadrado If you find some time during the next days it would generally be great if you also have some broader look onto the new code base. Would really be good if we have some more eyes on this and this is really some important milestone release once done.

[s1na]

@holgerd77 Definitely the more time we have to test the less bugs we'll have in the release. Specially that after listening to the last AllCoreDevs call, it doesn't seem clear at all yet which EIPs will likely make it to Istanbul so we can't really start with that yet.

Would you suggest we limit the changes to only bugfixes in this week, or also do other improvements?

Edit: Good catch by the way @alcuadrado, thanks for having a look

[holgerd77]

@s1na Wouldn't strictly limit this to bug fixing, things should nevertheless be of some more closing or fixing nature and not completely open new topics I would suggest (but also depends a bit). Especially if you want to further improve the structure or you are confident on further API simplifications/changes we should definitely do that.

[alcuadrado]

@alcuadrado If you find some time during the next days it would generally be great if you also have some broader look onto the new code base. Would really be good if we have some more eyes on this and this is really some important milestone release once done.

I can spend most of my day on EthereumJS today. I'll focus on this in particular.

[holgerd77]

😀

[holgerd77]

Looks good.