Maintain separate list of opcodes for Istanbul #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
force-pushed
the
group-opcodes-by-hf
branch
from
c616143
to
eccc8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 modifications:
dynamicfield from opcode info (fixes Unnecessary dynamic field in OpcodeInfo #573)CHAINIDopcode to an istanbul-specific list of opcodes and on instantiation of the VM updates the list of opcodes if HF is istanbul. This change is necessary for Add EIP-1884 support for Istanbul #581, and it can later on be generalized to every HF (as per discussion in Group opcodes based on HF #543). Another possible improvement is to store the list of opcodes in the VM instead of a global variable inopcodes.ts.