fix vm blockchain.delBlock parameter #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,8 @@ module.exports = function (blockchain, cb) { | |||
| }, function (err, results) { | |||
| if (err) { | |||
| // remove invalid block | |||
| self.stateManager.blockchain.delBlock(block, cb) | |||
| console.error(err) | |||
|
We need an optional logging mechanism -- the error here could be anything but we discard it and just attempt to delete the block. In my case the error was an important piece of evidence in tracking down a bug, but would have lost it.. any idea on optional logging mechanisms? just check |
|
Having a logging interface would be nice, but For starters it could be just an optional |
|
recap on a conversation with @kumavis ; I think he can get all the information need from vm.on('block', cb) instead of built in loggin. |
|
@kumavis will merge! just take out that console.log :) |
|
@wanderer removed |
evertonfraga
pushed a commit
to evertonfraga/ethereumjs-vm
that referenced
this pull request
Feb 11, 2020
Add tests for increased coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.