feat: importing ethashjs as @ethereumjs/ethash #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils not exists
Created with:
```graph TD
vm{VM}
common --> blockchain
common --> block
common --> vm
common --> tx
ethash --> blockchain
block --> blockchain
blockchain --> vm
block --> vm
tx --> vm
tx --> block
account --> vm```
|
This is ready for review. The failure is due to the coverage difference, now that Ethash is in. |
|
looks great! should i add a commit for #766 (comment) |
|
Sure! @ryanio |
evertonfraga
commented
Jun 15, 2020
| @@ -18,13 +18,10 @@ import { | |||
| getSeed | |||
| } from './util' | |||
| import type { LevelUp } from 'levelup' | |||
| import type { Block, BlockHeader } from '@ethereumjs/block' | |||
| @@ -122,8 +119,8 @@ export default class Ethash { | |||
| return keccak256(Buffer.concat(this.cache)) | |||
| } | |||
|
|
|||
| headerHash(header: BlockHeader) { | |||
| return rlphash(header.slice(0, -2)) | |||
| headerHash(rawHeader: Buffer[]) { | |||
There was a problem hiding this comment.
@ryanio the Buffer type seems correct here, but why was it BlockHeader first place? The tests that cover this function actually passed before this change, so I am a bit confused.
There was a problem hiding this comment.
It was a misunderstanding on my part of what the input was when I transcribed it to TS.
It didn't complain because I set BlockHeader to type any since block v3 still wasn't on npm.
ryanio
reviewed
Jun 15, 2020
evertonfraga
commented
Jun 15, 2020
ryanio
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the monorepify.sh script to import ethashjs to this monorepo.
Thanks to @ryanio for converting this library to this monorepo standards in no-time =)
Note: this PR should be merged with "Create merge commit", so all commits will be present on the master branch.