-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for a smooth onboarding #784
Conversation
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 90.48% 90.54% +0.05%
==========================================
Files 48 50 +2
Lines 3162 3182 +20
Branches 482 482
==========================================
+ Hits 2861 2881 +20
Misses 204 204
Partials 97 97
Continue to review full report at Codecov.
|
@jochem-brouwer I have added the changes you suggested. It is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Everton, this looks really good for some start and will likely be super-helpful for people (including us 😄) to get on board!
Will directly merge here since uncritical, then we have less interferences with people not being on latest master state.
Thanks @holgerd77! We can talk about improvements next week |
I know ran the instructions from this on a pretty-much newly setup repository (yesterday I deleted my local copy and just set up everything from scratch and initialized with I now pulled in the various changes from #787 into Command worked without direct error output. However in the VM there are now half of the packages missing, I get e.g. the following output for @ethereumjs/vm@4.1.3 /ethereumjs-vm/packages/vm
├── UNMET DEPENDENCY @ethereumjs/account@^3.0.0
├── UNMET DEPENDENCY @ethereumjs/block@^3.0.0
├── UNMET DEPENDENCY @ethereumjs/blockchain@^4.0.3
├── UNMET DEPENDENCY @ethereumjs/common@^1.5.1
├── UNMET DEPENDENCY @ethereumjs/tx@^2.1.2
├── UNMET DEPENDENCY async@3.2.0
├─┬ UNMET DEPENDENCY async-eventemitter@0.2.4
│ └── async@2.6.3
├── UNMET DEPENDENCY core-js-pure@3.6.5
├─┬ UNMET DEPENDENCY ethereumjs-util@7.0.2
│ ├── @types/bn.js@4.11.6
│ ├── bn.js@5.1.2
│ ├── create-hash@1.2.0
│ ├── ethjs-util@0.1.6
│ ├── keccak@3.0.0
│ ├── rlp@2.2.5
│ └── secp256k1@4.0.1
├── UNMET DEPENDENCY functional-red-black-tree@1.0.1
├─┬ UNMET DEPENDENCY merkle-patricia-tree@4.0.0
│ ├── @types/levelup@3.1.1
│ ├── ethereumjs-util@7.0.2
│ ├── level-mem@5.0.1
│ ├── level-ws@2.0.0
│ ├── readable-stream@3.6.0
│ ├── rlp@2.2.5
│ └── semaphore-async-await@1.5.1
├── UNMET DEPENDENCY rustbn.js@0.2.0
├── UNMET DEPENDENCY safe-buffer@5.2.1
├─┬ UNMET DEPENDENCY util-callbackify@1.0.0
│ └── object.getownpropertydescriptors@2.1.0
└─┬ UNMET DEPENDENCY util.promisify@1.0.1
├── define-properties@1.1.3
├── es-abstract@1.17.5
├── has-symbols@1.0.1
└── object.getownpropertydescriptors@2.1.0 deduped
npm ERR! missing: async@3.2.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: async-eventemitter@0.2.4, required by @ethereumjs/vm@4.1.3
npm ERR! missing: core-js-pure@3.6.5, required by @ethereumjs/vm@4.1.3
npm ERR! missing: ethereumjs-util@7.0.2, required by @ethereumjs/vm@4.1.3
npm ERR! missing: functional-red-black-tree@1.0.1, required by @ethereumjs/vm@4.1.3
npm ERR! missing: merkle-patricia-tree@4.0.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: rustbn.js@0.2.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: safe-buffer@5.2.1, required by @ethereumjs/vm@4.1.3
npm ERR! missing: util-callbackify@1.0.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: util.promisify@1.0.1, required by @ethereumjs/vm@4.1.3
npm ERR! missing: @ethereumjs/account@^3.0.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: @ethereumjs/block@^3.0.0, required by @ethereumjs/vm@4.1.3
npm ERR! missing: @ethereumjs/blockchain@^4.0.3, required by @ethereumjs/vm@4.1.3
npm ERR! missing: @ethereumjs/common@^1.5.1, required by @ethereumjs/vm@4.1.3
npm ERR! missing: @ethereumjs/tx@^2.1.2, required by @ethereumjs/vm@4.1.3
npm ERR! missing: async@2.6.3, required by async-eventemitter@0.2.4
npm ERR! missing: @types/bn.js@4.11.6, required by ethereumjs-util@7.0.2
npm ERR! missing: rlp@2.2.5, required by ethereumjs-util@7.0.2
npm ERR! missing: @types/node@14.0.14, required by @types/bn.js@4.11.6
npm ERR! missing: safe-buffer@5.2.1, required by cipher-base@1.0.4
npm ERR! missing: safe-buffer@5.2.1, required by md5.js@1.3.5
npm ERR! missing: safe-buffer@5.2.1, required by hash-base@3.1.0
npm ERR! missing: safe-buffer@5.2.1, required by sha.js@2.4.11
npm ERR! missing: bn.js@4.11.9, required by rlp@2.2.5
npm ERR! missing: elliptic@6.5.2, required by secp256k1@4.0.1
npm ERR! missing: bn.js@4.11.9, required by elliptic@6.5.2
npm ERR! missing: @types/levelup@3.1.1, required by merkle-patricia-tree@4.0.0
npm ERR! missing: ethereumjs-util@7.0.2, required by merkle-patricia-tree@4.0.0
npm ERR! missing: level-ws@2.0.0, required by merkle-patricia-tree@4.0.0
npm ERR! missing: level-mem@5.0.1, required by merkle-patricia-tree@4.0.0
npm ERR! missing: rlp@2.2.5, required by merkle-patricia-tree@4.0.0
npm ERR! missing: semaphore-async-await@1.5.1, required by merkle-patricia-tree@4.0.0
npm ERR! missing: @types/abstract-leveldown@5.0.1, required by @types/levelup@3.1.1
npm ERR! missing: @types/node@11.15.16, required by @types/levelup@3.1.1
npm ERR! missing: xtend@4.0.2, required by level-ws@2.0.0
npm ERR! missing: memdown@5.1.0, required by level-mem@5.0.1
npm ERR! missing: abstract-leveldown@6.2.3, required by memdown@5.1.0
npm ERR! missing: functional-red-black-tree@1.0.1, required by memdown@5.1.0
npm ERR! missing: immediate@3.2.3, required by memdown@5.1.0
npm ERR! missing: safe-buffer@5.2.1, required by memdown@5.1.0
npm ERR! missing: buffer@5.6.0, required by abstract-leveldown@6.2.3
npm ERR! missing: xtend@4.0.2, required by abstract-leveldown@6.2.3
npm ERR! missing: safe-buffer@5.2.1, required by string_decoder@1.3.0
npm ERR! missing: es-abstract@1.17.5, required by object.getownpropertydescriptors@2.1.0
npm ERR! missing: es-abstract@1.17.5, required by util.promisify@1.0.1
npm ERR! missing: object-keys@1.1.1, required by es-abstract@1.17.5
npm ERR! missing: object-inspect@1.7.0, required by es-abstract@1.17.5
npm ERR! missing: string.prototype.trimleft@2.1.2, required by es-abstract@1.17.5
npm ERR! missing: string.prototype.trimright@2.1.2, required by es-abstract@1.17.5
npm ERR! missing: es-abstract@1.17.5, required by string.prototype.trimleft@2.1.2
npm ERR! missing: es-abstract@1.17.5, required by string.prototype.trimstart@1.0.1
npm ERR! missing: es-abstract@1.17.5, required by string.prototype.trimright@2.1.2
npm ERR! missing: es-abstract@1.17.5, required by string.prototype.trimend@1.0.1 I would very much assume there is something broken in the setup scripts? Or am I missing something on the application side? |
Update: ah, this actually breaks my whole installation, and I am a bit lost on how to get out of this again (easily) without setting everything up from scratch again? |
@holgerd77 We started using lerna hoisting, that installs most of the node modules in the root folder. So the output you got is quite valid. What other side-effect did you have while using it? You can temporarily remove |
I originally stumbled upon this because I couldn't run the tests any more after doing these steps, now I got there: $ npm run build && node -r ts-node/register --stack-size=1500 ./node_modules/tape/bin/tape './tests/api/runBlock.js'
> @ethereumjs/vm@4.1.3 build /ethereumjs-vm/packages/vm
> ethereumjs-config-build
+ exec tsc -p ./tsconfig.prod.json
Error: Cannot find module '/ethereumjs-vm/packages/vm/node_modules/tape/bin/tape' |
Ah, ok, got it myself, this is because of the direct path referencing I guess? So we need to update these kind of things I suppose. |
yes! My fault, then. I took care to update all direct path referencing in all package.json, but forgot the test documentation. |
After hoisting, the
|
Basic docs, showing how to quickly get started.
Please let me know your wishlist for these docs, as I will grow them in the following days.