Convert testUtil.setupPreConditions to async #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ryanio
force-pushed
the
setupPreConditions-to-async
branch
2 times, most recently
from
8648f4f
to
7fc238c
Compare
ryanio
force-pushed
the
setupPreConditions-to-async
branch
from
7fc238c
to
dba10e0
Compare
holgerd77
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Looks good, thanks for that Ryan (really wished I would have kept a copy of my code of the transition here I once tried to see what I did wrong on this).
We should really move this tests to TypeScript as well - as some side note - no reason that we keep especially the VM tests on JS. Maybe after all this base refactoring is some good PIT for that.
| } | ||
|
|
||
| /** | ||
| <<<<<<< HEAD | ||
| ======= |
There was a problem hiding this comment.
Ups. How funny is that that this stayed unnoticed in the code without breaking anyhting? 🤪 Lol.
There was a problem hiding this comment.
I think it's the first time I see a conflict within the comments!
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
testUtil.setupPreConditionsto async.It also removes
VMTestsRunner.jssince it is unused.