Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonce option for runCall #801

Closed
wants to merge 2 commits into from
Closed

Conversation

jochem-brouwer
Copy link
Member

Closes #613.

This adds the nonce option for runCall. It adds a test which explicitly checks that the created addresses are the expected ones and also creates collisions by trying to re-deploy transactions with equal nonces.

For a discussion why I think it does make no sense to add this option to runCode, see #613.

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #801 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   84.49%   84.41%   -0.09%     
==========================================
  Files          19       17       -2     
  Lines        1245     1238       -7     
  Branches      246      246              
==========================================
- Hits         1052     1045       -7     
  Misses        125      125              
  Partials       68       68              
Flag Coverage Δ
#account 92.85% <ø> (ø)
#block 80.18% <ø> (+0.02%) ⬆️
#blockchain 84.50% <ø> (-0.21%) ⬇️
#common 93.60% <ø> (-0.19%) ⬇️
#ethash 86.30% <ø> (ø)
#tx 94.02% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
packages/blockchain/src/cache.ts 66.66% <0.00%> (-14.59%) ⬇️
packages/common/src/genesisStates/index.ts 100.00% <0.00%> (ø)
packages/tx/src/index.ts
packages/common/src/chains/index.ts
packages/common/src/hardforks/index.ts
packages/block/src/index.ts 100.00% <0.00%> (ø)
packages/block/src/header-from-rpc.ts 87.50% <0.00%> (+20.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703fbd9...9af845e. Read the comment docs.

@jochem-brouwer
Copy link
Member Author

Hmm looks like tests are failing, let's fix that first.

@jochem-brouwer
Copy link
Member Author

Will close this PR, for discussion see #613

@ryanio ryanio deleted the add-nonce-runcode-runcall branch October 28, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM: Create collisions using runCode() and runCall()
1 participant