Add frontier support

[jochem-brouwer]

Builds upon #815

Linked issue: #652

[codecov]

Codecov Report

Merging #828 into master will decrease coverage by 0.22%.
The diff coverage is 50.00%.

Flag	Coverage Δ
#account	92.85% <ø> (ø)
#block	77.58% <ø> (-0.49%)	⬇️
#blockchain	81.03% <ø> (-0.31%)	⬇️
#common	93.98% <ø> (ø)
#ethash	83.33% <ø> (ø)
#tx	94.16% <ø> (+0.13%)	⬆️
#vm	92.49% <50.00%> (-0.32%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jochem-brouwer]

Frontier blockchain tests
1..2751
# tests 2751
# pass  2530
# fail  221

It seems that the block package will need some changes too (Homestead changed the difficulty algorithm). The Tx changes seem to be available already.

After 51c7099: (note: currently due to how tests work the test pass amount stays the same, but only the fail amount will decrease)

1..2744
# tests 2744
# pass  2530
# fail  214

After e9b70f1:

1..2650
# tests 2650
# pass  2530
# fail  120

[jochem-brouwer]

Linking some Geth code here for reference (what happens if a CREATE message (either by normal message call or via CREATE opcode) finishes, but there is not enough gas to pay for the code deposit gas (200 gas per byte)?)

https://github.com/ethereum/go-ethereum/blob/295693759e5ded05fec0b2fb39359965b60da785/core/vm/evm.go#L467

https://github.com/ethereum/go-ethereum/blob/295693759e5ded05fec0b2fb39359965b60da785/core/vm/instructions.go#L622

[jochem-brouwer]

Changed the base so it will be easier to review this one.

[holgerd77]

@jochem-brouwer: Pre-Homestead is already integrated in the block package difficulty calculation, so we are fine on this front! 😄

[holgerd77]

Rebased this, @jochem-brouwer let me know if this was a counter service (in german we would say: "Bärendienst", bear service) and it rather messed something up, was intended to be some supportive task though. 😄

[holgerd77]

Rebased this on top of #833 and added Chainstart runs to state and blockchain tests.

[ryanio]

hm do we need an await here?

Suggested change

	this._state.commit()
	await this._state.commit()

[jochem-brouwer]

Tests pass! Most errors where actually in the test suite, not in the code (with a few exceptions). Really good to see that most of the code of Frontier was already in block and tx (see point 2 and 4 of EIP 2)

[holgerd77]

Rebased this.

[holgerd77]

Went through the changes on a commit basis and had a look at the test output, this actually looks good now.

All HFs implemented. Congratulations @jochem-brouwer, great work!!! 🎊 😀

[holgerd77]

(ah, except from the DAO, I wonder if we shouldn't really do this and complete here, this shouldn't be too much work? 🤔 )

Here are the I would think core parts of the geth implementation.

EIP for the DAO HF is EIP-779.

[jochem-brouwer]

Yeah we should do it, if you want I can start on this tomorrow? If it turns out to be rather complex it should not be something which blocks the V5 release though. (But it seems to be rather easy).

[holgerd77]

That would be great! 😄