Alternative EIP-based HF file format in Common as preparation for Yolo v2 integration #876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative HF file format in Common which further decouples the HF and EIP structure, the following is an example for the new format used in the
berlin.json
HF file:This generally allows for more flexibility when defining chain and HF structures and explicitly prepares for integrating ephemeral testnets like the upcoming
Yolo v2
testnet which integrates the same EIPs as theberlin
HF. In the current structure this would demand the duplication of all parameters affected.I first wanted to go down the whole path and convert all HF files - we actually still can do this - but then I realized that this would lead to a lot of extra files created respectively file reads necessary on Common instantiation. Not sure if this is an issue but under the light of the current performance discussions I couldn't decide on a design here (an alternative would be to inline all EIP configs under one eip.json file, a bit on the cost of oversight). We can discuss this in the call later the day.