Blockchain: Add reorg test + do not skip any reorg test in VM #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochem-brouwer
added
PR state: needs review
package: blockchain
package: vm
PR state: WIP
and removed
PR state: needs review
labels
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
added
PR state: do-not-merge
PR state: needs review
and removed
PR state: WIP
PR state: do-not-merge
labels
jochem-brouwer
force-pushed
the
add-reorg-test
branch
from
aacf3b3 to
b82f7a0
Compare
|
@ryanio had to rebase this one, could you re-approve? 😄 |
ryanio
approved these changes
Oct 30, 2020
holgerd77
reviewed
Nov 4, 2020
| st.end() | ||
| } | ||
| ) | ||
| }) |
There was a problem hiding this comment.
This is really a beautiful beautiful test 🤩 , would even call this educational. Great.
There was a problem hiding this comment.
(and all the comments along are fantastic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #879
This PR cherry-picks from #895 and does:
In this test, we create two chains: one chain which has a low difficulty and another one which has a higher difficulty, but this chain is actually 1 block behind the other chain. This is possible due to the difficulty formula: if time since last block > 18 seconds, decrease the difficulty, if it is < 9 seconds, increase the difficulty. Block number is thus not a good identifier to find the "best chain" (which has the highest sum of difficulties, i.e. the Total Difficulty). In practice, this test first writes 65 blocks to the chain. Then it puts all the blocks in (64 blocks) which have a higher total difficulty: this thus re-orgs 65 blocks. Without any necessary change this test passes. Thus, we can also: