Clean up getTests function, remove async/await library

[whymarrh]

Fixes #37

This PR cleans up getTests, also replacing the async-await library with native async/await.

[holgerd77]

CI is failing, can you also update this PR to run CI on Node 8, 10 and eventually 11?

[holgerd77]

We should really add ethereumjs/ethereumjs-config#16 (Git hooks), I also stumble upon this regularly (linting errors). @whymarrh if you want you can open a small PR on this towards the blockchain or other library so that we get started, should be a pretty small one.

[whymarrh]

CI is failing, can you also update this PR to run CI on Node 8, 10 and eventually 11?

On it

[whymarrh]

@holgerd77 should be good now, I cleaned up the Travis config as well

[holgerd77]

1. These code changes are rather heavy. Can you please add a test case for this method, since "getTests" is completely untested atm, so that we can make sure that API functionality is working as before?
2. Is Node 11 not working?
3. Can you please re-add the JSDoc comment for the method?

[whymarrh]

I added a test case for the default arguments, but I'm not quite sure how this is used in the wild—what other tests would be useful?

[rumkin]

While using async/await in source code it's better to set minimum node.js version to 8.0 in package.json:

{ "engines" : { "node" : ">=8.0" } }

And even better to define last tested version as an upper bound to avoid regression issues.

[holgerd77]

Ok, have also done a short integration test on the VM, looks good! 😄

[holgerd77]

Hmm, might have been merged too early/quickly, the integration tests I did on the VM show a huge decrease in coverage - see ethereumjs/ethereumjs-monorepo#477 - I think the blockchain tests are not run correctly (at all).

Can you have a look at that?

[whymarrh]

Can you have a look at that?

I added a old commit hash to ethereumjs/ethereumjs-monorepo#477 so we have something to compare against. I can take a look at what's happening—this is weird because we have a test for methods that the vm is using that used to pass as well.

[holgerd77]

You can have a look at the CI run, the state tests are just not running, respectively all skipped, this should likely be the cause for coverage decrease (see CircleCI coveralls run).