Enforce Buffer input type for hashPersonalMessage

ethereumjs · Apr 28, 2020 · e221440 · e221440
1 parent 391dfc1
commit e221440
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/signature.ts b/src/signature.ts
@@ -2,6 +2,7 @@ import * as secp256k1 from 'secp256k1'
 import * as BN from 'bn.js'
 import { toBuffer, setLengthLeft, bufferToHex } from './bytes'
 import { keccak } from './hash'
+import { assertIsBuffer } from './helpers'
 
 export interface ECDSASignature {
   v: number
@@ -134,6 +135,7 @@ export const isValidSignature = function(
  * used to produce the signature.
  */
 export const hashPersonalMessage = function(message: Buffer): Buffer {
+  assertIsBuffer(message)
   const prefix = Buffer.from(
     `\u0019Ethereum Signed Message:\n${message.length.toString()}`,
     'utf-8',

diff --git a/test/signature.spec.ts b/test/signature.spec.ts
@@ -94,6 +94,13 @@ describe('hashPersonalMessage', function() {
       Buffer.from('8144a6fa26be252b86456491fbcd43c1de7e022241845ffea1c3df066f7cfede', 'hex'),
     )
   })
+  it('should throw if input is not a buffer', function() {
+    try {
+      hashPersonalMessage((<unknown>[0, 1, 2, 3, 4]) as Buffer)
+    } catch (err) {
+      assert(err.message.includes('This method only supports Buffer'))
+    }
+  })
 })
 
 describe('isValidSignature', function() {