Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

New release v6.2.0 #222

Merged
merged 2 commits into from
Nov 7, 2019
Merged

New release v6.2.0 #222

merged 2 commits into from
Nov 7, 2019

Conversation

holgerd77
Copy link
Member

No description provided.

@holgerd77 holgerd77 requested review from alcuadrado and s1na November 5, 2019 16:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.336% when pulling 98f4c75 on new-release-v620 into f158d29 on master.

@holgerd77
Copy link
Member Author

Hmm, the travis-ci/push build went through but wasn't reported for some reason. 🤔 Have re-triggered.

@holgerd77
Copy link
Member Author

Ah ok, this is working now. Ready for review.

@alcuadrado
Copy link
Member

Thanks for preparing this @holgerd77! This release has a few changes that will make the library much better.

I think this is missing from the changelog: #168

Or is it not included in the release? IMO it's pretty important to release that upgrade soon, as it's breaking things like web3 (see: web3/web3.js#3181 )

@evertonfraga
Copy link
Contributor

evertonfraga commented Nov 6, 2019

@alcuadrado it is included, as shown on master.

I'm sending a commit adding it to the changelog.

Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this @evertonfraga ! LGTM now

@holgerd77
Copy link
Member Author

@alcuadrado Phew, the PR which actually triggered this release, hmm, thanks @evertonfraga for adding. Will now merge and release.

@holgerd77 holgerd77 merged commit 9354465 into master Nov 7, 2019
@holgerd77 holgerd77 deleted the new-release-v620 branch November 7, 2019 10:39
@holgerd77
Copy link
Member Author

Released this as v6.2.0 on npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants