Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly calculate totalgas for large return values #275

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Properly calculate totalgas for large return values #275

merged 1 commit into from
Feb 13, 2018

Conversation

axic
Copy link
Member

@axic axic commented Feb 13, 2018 •
edited
Loading

Fixes #235. Split off #272.

Reason: indutny/bn.js#176

@axic axic requested a review from holgerd77 February 13, 2018 13:54
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.462% when pulling 5c1a869 on totalgas-large-return into 8de73f9 on master.

@axic
Copy link
Member Author

axic commented Feb 13, 2018

@holgerd77 merge merge? :)

holgerd77
holgerd77 approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can do. 😄

@holgerd77 holgerd77 merged commit 688aec6 into master Feb 13, 2018
@holgerd77 holgerd77 deleted the totalgas-large-return branch February 13, 2018 20:18
holgerd77 added a commit that referenced this pull request Mar 11, 2021
@holgerd77
Merge pull request #275 from ethereumjs/add-account-class
c5dca47 
Add Account class
This was referenced Aug 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axic @coveralls @holgerd77 @evertonfraga @wanderer