Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

[WIP] include parity node via docker #1

Merged
merged 5 commits into from
Sep 2, 2017
Merged

Conversation

whilei
Copy link
Contributor

@whilei whilei commented Aug 28, 2017

  • TODO: setup bootnodes connection for parity and restrict discovery/reserved peers

@splix
Copy link
Contributor

splix commented Aug 28, 2017

@whilei do you think they merge ecip1017 code into master? I didn't check it. If merged, maybe it makes sense to base docker on their existing image and just add chain config and launch scripts?

@whilei
Copy link
Contributor Author

whilei commented Aug 28, 2017

They did merge our PR to master (openethereum/parity-ethereum#5741), so I based the docker file off their master (https://github.com/paritytech/parity/blob/master/docker/ubuntu/Dockerfile). I didn't see a default JSON config file or example, so based the config on https://github.com/paritytech/parity/wiki/Chain-specification and an example repo https://github.com/5chdn/crossclient-chainspec.

See https://github.com/whilei/ecip1017test/blob/1a002d579b94c9dd3eb4d982831bbab293784de8/docker/parity/parity.json#L19 for relevant ecip1017 json config.

Still todo is the launch script (and extract that part from current dockerfile) and make sure the config file works. I've been having some network connection issues with parity on my local private network (https://github.com/ethereumproject/homerun/blob/master/example-basedir/green-parity/flags.conf -- parity says: Disconnect 0), so am debugging chain/genesis/network configs locally so far, and will take lessons learned from that then to the docker environment if relevant.

@splix
Copy link
Contributor

splix commented Aug 29, 2017

I mean instead of full compilations you can have just:

FROM ethcore/parity

COPY docker/parity/ecip1017chain.json /opt/parity/ecip1017chain.json
CMD ... (call a .sh script)

whilei added 3 commits August 30, 2017 09:52
solution: use config generator to make file and add necessary fields
like chainID, networkID
solution: use parity/parity image, assumes docker build is from their master branch
solution: include that

bootnodes can be specified as a file
enables rpc
there is no mining option
@splix splix merged commit 06ecc28 into ethereumproject:master Sep 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants