This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
[ECIP-1041] Difficulty bomb diffusion implementation #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rel https://github.com/ethereumproject/ECIPs/blob/ecip-1036/ECIPs/ECIP-1036.md - also separates fork edge difficulty tests for morden vs mainnet
whilei
force-pushed
the
defused-enabled
branch
from
9a9f4fc to
259e698
Compare
whilei
changed the title
whilei
changed the title
elaineo
approved these changes
Nov 16, 2017
splix
suggested changes
Nov 18, 2017
core/config/mainnet.json
Outdated
| @@ -26774,6 +26774,18 @@ | |||
| } | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "Paradise", | |||
There was a problem hiding this comment.
I don't like words Paradise and Bomb used together here, because it's well known combination from Islamic Jihad. What people will think? Let's use just "Diffuse Difficulty Bomb" instead
core/config/morden.json
Outdated
| @@ -112,6 +112,18 @@ | |||
| } | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "Paradise", | |||
There was a problem hiding this comment.
Let's use just "Diffuse Difficulty Bomb" instead
core/config/morden.json
Outdated
| }, | ||
| { | ||
| "name": "Paradise", | ||
| "block": 2452163, |
There was a problem hiding this comment.
maybe something closer? like 2150721
|
@splix -- your suggested changes have been addressed |
whilei
changed the title
solution: bump to 5900000, per https://github.com/ethereumproject/ECIPs/pull/87/files
|
@splix PTAL -- ok to approve and merge ASAP? (Given ethereumproject/ECIPs#87 is merged, and passing test demo https://github.com/ETCDEVTeam/ecip1041test) /cc @tzdybal |
splix
approved these changes
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures fork for implementation in #408.
Made up the name "Paradise" out of the blue.Rel ethereumproject/ECIPs#87