getAvatar returning null but domain has an avatar

[githubdoramon]

Describe the bug
getAvatar returns null although ENS has an avatar

Reproduction steps
Use getAvatar on bratly.eth for example, I will return null. This happens because on the getAvatar function the following check is done

if (!metadata || typeof(metadata.image) !== "string" || !metadata.image.match(/^https:\/\//i)) {
  return null;
}

but NFT can have ipfs hashes as images instead of an https link. Ideally function should check for ipfs links as well

[ricmoo]

The ENS name "bratly.eth" is not registered, did you mean "brantly.eth"? That one works.

But if you have any examples that don’t, please let me know. :)

[githubdoramon]

Sry... was a typo... I meant "brantly.eth". The following code returns null (using ethers 5.5.2)

 const provider = new ethers.providers.InfuraProvider("homestead", {
        projectId: xxxx, -> > purposely hidden
        projectSecret: xxxx -> purposely hidden
    });

    const resolver = await provider.getResolver("brantly.eth");
    console.log('avatar ', await resolver?.getAvatar())

[githubdoramon]

Updating, works for brantly.eth (my node modules had the wrong ethers version).

But still doesn't work for this example - 9tails.eth - cause its avatar is an ipfs link

[slingncrypto]

I also observe this behavior when Avatar is set to value which should ultimately be resolved to a base64 encoded image:

    const resolver = await $provider.getResolver('slingn.eth');
    const avatar = await resolver.getAvatar();
    console.log(`Avatar: ${avatar}`);
    const avatarMetaData = await resolver.getText("avatar");
    console.log(`Avatar Metadata: ${avatarMetaData}`);

[ricmoo]

This has been fixed in 5.5.3. Try it out and let me know if there are any issues.

Thanks! :)

[githubdoramon]

works :)

Thanks @ricmoo

[rhamnett]

Think you should add arweave ar:// too

[ricmoo]

I’m not sure what ar:// is, but keep in mind I only support open protocols that do not require large amounts of additional code to implement, and that are quite common.

[rhamnett]

@ricmoo thanks for the prompt reply. Arweave is a permaweb storage like ipfs. It's supported and popular on opensea and solana NFTs. The urls are like this ar://{hash} it can be simply fetched via a gateway like this: https://arweave.net/{hash}

[rhamnett]

See https://docs.opensea.io/docs/metadata-standards