-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet.encry #3075
Comments
it works well,but can't import to metamask |
I have a theory about the root cause. The generated encrypted JSON has a Make sure to change |
Found the culprit:
@ricmoo I can issue a PR to fix this, but it's literally a 1-char diff. To corroborate the theory, if you go to the Web3 Secret Storage Definition section of the Ethereum wiki, you will notice that all |
Thanks! Yeah, don’t worry about a PR. I’ll test and make the change. Thanks for the research though. :) |
Just to mention this was there since ethers v4. I remember from my first web3 job for a startup, when I looked into this issue that some investors weren't able to load their keystore on the application. Not sure if there is a consensus/standard on using |
Awesome! Thanks for the info by the way. This definitely didn't used to be the case; all the test vectors generated by Geth have a It's also why the ethers parser allows any case to be used, because it was so chaotic. :) It will be fixed in v5.7.0. |
This has been updated in v5.7.0. Try it out and let me know if you have any problems. Thanks! :) |
Ethers Version
5.6.8
Search Terms
wallet.encrypt
Describe the Problem
when I create a keystore,I can't import the json file with metamask, but I can load ethers.Wallet.fromEncryptedJson
Code Snippet
Contract ABI
No response
Errors
Environment
node.js (v12 or newer)
Environment (Other)
"secp256k1": "^4.0.3" "keccak": "^3.0.2"
The text was updated successfully, but these errors were encountered: