Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FallbackProvider does not forward blockTag in call. #3168

Closed
ricmoo opened this issue Jul 14, 2022 · 1 comment
Closed

FallbackProvider does not forward blockTag in call. #3168

ricmoo opened this issue Jul 14, 2022 · 1 comment
Assignees
@ricmoo
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Jul 14, 2022 •
edited
Loading

Ethers Version

5.6.9

Search Terms

No response

Describe the Problem

The optional blockTag parameter is dropped in the FallbackProvider during call in the getRunner function.

It should be passed along.

(reported by @zemse via discord)

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

Ethereum (mainnet/ropsten/rinkeby/goerli)

Environment (Other)

No response
@ricmoo ricmoo added the investigate Under investigation and may be a bug. label Jul 14, 2022
@ricmoo ricmoo self-assigned this Jul 14, 2022
@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Jul 14, 2022
ricmoo added a commit that referenced this issue Jul 14, 2022
@ricmoo
Forward any blockTag along in the FallbackProvider during call (#3168).
ab43e7d
@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Jul 14, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Aug 19, 2022

This has been fixed in v5.7.0.

Try it out and let me know if there are any problems.

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 19, 2022
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Aug 19, 2022
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Forward any blockTag along in the FallbackProvider during call (ether…
5c2cf75 
…s-io#3168).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo