-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI Coder Fails to validate correctly provided arguments #4583
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
v6
Issues regarding v6
Comments
KyrylR
added
investigate
Under investigation and may be a bug.
v6
Issues regarding v6
labels
Feb 8, 2024
Thanks! I'll investigate fist thing in the morning. |
ricmoo
added
on-deck
This Enhancement or Bug is currently being worked on.
bug
Verified to be an issue.
next-patch
Issues scheduled for the next arch release.
and removed
investigate
Under investigation and may be a bug.
labels
Feb 8, 2024
I've verified this is an issue and will go out in the next patch release (hopefully within a few hours). For minimal reproduction, this example is easier to use to reproduce: const coder = new ethers.AbiCoder();
const encoded = coder.encode([ "string", "string" ], [ { }, "symbol" ]);
console.log(encoded);
console.log(coder.decode([ "string", "string" ], encoded)); |
ricmoo
added a commit
that referenced
this issue
Feb 14, 2024
Fixed in v6.11.1. Thanks! :) |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
next-patch
Issues scheduled for the next arch release.
labels
Feb 14, 2024
This was referenced May 22, 2024
This was referenced May 26, 2024
This was referenced Aug 1, 2024
This was referenced Aug 16, 2024
Open
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
v6
Issues regarding v6
Ethers Version
6.10.0
Search Terms
abi
Describe the Problem
Abi Coder encoded an invalid value without throwing an error for the invalid type
Expected result:
Actual result:
It treated the complex object as an empty string
Code Snippet
Contract ABI
No response
Errors
No response
Environment
Hardhat
Environment (Other)
No response
The text was updated successfully, but these errors were encountered: