Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address checksum errors being reported as ENS name resolution errors #694

Closed
rjchow opened this issue Jan 1, 2020 · 2 comments
Closed

Address checksum errors being reported as ENS name resolution errors #694

rjchow opened this issue Jan 1, 2020 · 2 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@rjchow
Copy link

rjchow commented Jan 1, 2020 •
edited
Loading

I am unsure if this is intended behaviour or a bug, but resolveName()is swallowing the errors from getAddress()

It is confusing as these are address errors being reported as ENS name resolution errors.

Happy to write a fix if it is confirmed this is unintended!

To reproduce:

> provider.getBalance("0x532C9Ff853CA54370D7492cD84040F9f8099f11b")

Error: ENS name not configured (operation="resolveName(\"0x532C9Ff853CA54370D7492cD84040F9f8099f11b\")", version=4.0.41)

> ethers.utils.getAddress("0x532C9Ff853CA54370D7492cD84040F9f8099f11b")
{ Error: bad address checksum (arg="address", value="0x532C9Ff853CA54370D7492cD84040F9f8099f11b", version=4.0.41)
@ricmoo ricmoo added investigate Under investigation and may be a bug. bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Jan 3, 2020
ricmoo added a commit that referenced this issue Jan 8, 2020
@ricmoo
Fixed resolveName when name is an address with an invalid checksum (#694
1e72fc7 
).
ricmoo added a commit that referenced this issue Jan 8, 2020
@ricmoo
Fix resolveName when name is an address with an invalid checksum (#694).
bd066b8
@ricmoo
Copy link
Member

ricmoo commented Jan 8, 2020

I've fixed this and published it in v5, available in 5.0.0-beta.164.

I've added the fix in v4 too, but since it is relatively low impact, I am holding off on publishing it. If you need it sooner, let me know and I can publish it, otherwise I'll wait a few more days until I have other fixes to push with it.

Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jan 8, 2020
@rjchow
Copy link
Author

rjchow commented Jan 8, 2020

No hurry, thanks!

@rjchow rjchow closed this as completed Jan 8, 2020
@julien-marchand julien-marchand mentioned this issue Feb 21, 2020
Closed
@ricmoo ricmoo mentioned this issue Mar 10, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Apr 25, 2020
Open
michaeltout pushed a commit to michaeltout/ethers.js that referenced this issue Aug 23, 2020
@ricmoo
Fixed resolveName when name is an address with an invalid checksum (e…
816e840 
…thers-io#694).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @rjchow