-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem verifying personal_sign signatures produced by ledger (v5) #893
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Comments
I’ll look into this shortly. |
Hey @ricmoo any update on this? :) |
I've updated the issue #933 with this and will track progress there. I've found the problem and am working on the fix right now. |
ricmoo
added a commit
that referenced
this issue
Jul 8, 2020
This should be fixed in 5.0.5. Try it out and let me know. :) |
Confirmed to be working with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Initially thought this was a MetaMask issue but looks like it's a bug in ethers v5, ref
Describe the bug
When verifying a
personal_sign
signature from a Ledger hardware walletethers@5
will return the incorrect address.To Reproduce
personal_sign
signature with metamask in the browser console using a ledger device:@ethersproject/wallet
in a node console:ethers@4
in a node console:Expected behavior
When recovering the signature the same address as used in MetaMask should be returned using the
ethers@5
library.The text was updated successfully, but these errors were encountered: