Fix the usage description of block.difficulty and block._difficulty in v5 #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It can still return a number of the difficulty fits in 53 bits, it’s only null when it exceeds it. I’ll update the docs shortly, as I have other docs changes coming. |
|
Oh, I got it! I frequently got Thanks for explaining how the property is working. |
ricmoo
added
documentation
ricmoo
added a commit
that referenced
this pull request
May 1, 2022
ricmoo
added a commit
that referenced
this pull request
May 1, 2022
|
Merged! Thanks! :) |
ricmoo
added
fixed/complete
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #2001 & #2036,
block.difficultycould give results that overflow IEEE754 number representation. Therefore, @ricmoo had fixed this issue, but it seems that the docs didn't updated yet.