Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts: Do not run out of stack and extract string revert reason #3308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ilya-bobyr
Copy link

This PR should help address #2849, but it might not be enough to fully get us there.

    await expect(contract.call()).to.revertedWith("revert message");

still does not really work for me. I see:

     AssertionError: Expected transaction to be reverted with revert message, but other exception was thrown: Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="call()", data="0xdeadbeef", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

But it still seems a step in the right direction as it fixes a stack overflow, as well as actually extracts the right error message from the transaction execution result.

@ilya-bobyr ilya-bobyr changed the title Reverts: Do not run out of stack and extrac string reasons Reverts: Do not run out of stack and extract string revert reason Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant