feat: bee-js revamp #690
Open
feat: bee-js revamp #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cafe137
commented
Feb 13, 2025
Cafe137
commented
Feb 14, 2025
| @@ -8,7 +8,7 @@ import { Flex } from './Flex' | |||
| import QRCodeModal from './QRCodeModal' | |||
|
|
|||
| interface Props { | |||
| address: string | undefined | |||
| address: EthAddress | undefined | |||
There was a problem hiding this comment.
This component is a mess. BLOCKCHAIN_EXPLORER_URL is no longer available, it is used for transaction IDs, not ethereum addresses, and only used by CashoutModal ?!
Cafe137
commented
Feb 14, 2025
src/utils/rpc.ts
Outdated
There was a problem hiding this comment.
Would be great to standardise this and re-use between projects.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.