fix!: correctly return reject promise for promise returning fnc #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
fix/async-unification
branch
from
821375c to
d5e89db
Compare
nugaon
reviewed
May 26, 2021
nugaon
approved these changes
May 26, 2021
AuHau
force-pushed
the
fix/async-unification
branch
from
c1c8e4b to
64bd451
Compare
AuHau
force-pushed
the
fix/async-unification
branch
from
4dedb8e to
8dad0d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311.
This PR is breaking as the previous behavior was throwing errors and now will be returning rejected Promise instead.
As part of the PR I have updated ESLint dependencies, bit modified the
ban-ts-commandrule, and did a general sweep of the codebase to remove ESlint warnings.Also I would propose to change the unused imports rule from Warning to Error.