Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move sleep to have all code in src #696

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: move sleep to have all code in src #696

merged 1 commit into from
May 26, 2022

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented May 26, 2022

So... 😅

My IDE was trigger-happy and I haven't noticed it. When implementing the waitForUsable feature, I have copy&pasted Aron's solution, which used the sleep function and IDE noticed that we have this function in test/utils.ts file so it just imported that and I have not noticed that.

Thanks to this the tsc compilation changed the structure of the compiled files as it has to now import something from ./test folder and so it changed the ./dist/cjs/ folder structure into containing subfolders src and test as this:

cjs
├── package.json
├── src
│   ├── bee-debug.js
│   ├── bee.js
│   ├── chunk
│   ├── feed
│   ├── index.js
│   ├── modules
│   ├── types
│   └── utils
└── test
    └── utils.js

This, unfortunately, breaks the package as the entry file ./dist/cjs/index.js is not in the expected place.

@AuHau AuHau merged commit 19171cc into master May 26, 2022
@AuHau AuHau deleted the fix/move-sleep branch May 26, 2022 10:32
@bee-worker
Copy link
Collaborator

Release v4.1.1 addresses this.

@agazso
Copy link
Member

agazso commented May 26, 2022

Maybe we can add a test for this in the release pipeline so we don't accidentally break this in the future?

@AuHau
Copy link
Contributor Author

AuHau commented May 26, 2022

@agazso #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants