chequebook: remove erc20 bindings #1362
Conversation
ralph-pichler
force-pushed
the
factory_no_bindings
branch
2 times, most recently
from
28828d4 to
7efc2a6
Compare
ralph-pichler
force-pushed
the
erc20_no_bindings
branch
from
30cff89 to
5399c7d
Compare
ralph-pichler
force-pushed
the
erc20_no_bindings
branch
from
5399c7d to
db21eb5
Compare
ralph-pichler
added
ready for review
| @@ -138,7 +131,7 @@ func Init( | |||
| if err == storage.ErrNotFound { | |||
| logger.Info("no chequebook found, deploying new one.") | |||
| if swapInitialDeposit.Cmp(big.NewInt(0)) != 0 { | |||
| err = checkBalance(ctx, logger, swapInitialDeposit, swapBackend, chainId, overlayEthAddress, erc20BindingFunc, erc20Address, 20*time.Second, 10) | |||
| err = checkBalance(ctx, logger, swapInitialDeposit, swapBackend, chainId, overlayEthAddress, erc20Service, 20*time.Second, 10) | |||
There was a problem hiding this comment.
can we extract the last two arguments to be declared at the beginning of the file?
There was a problem hiding this comment.
done. as they are constants I also removed them as arguments.
| request := &transaction.TxRequest{ | ||
| To: &c.address, | ||
| Data: callData, | ||
| GasPrice: nil, |
There was a problem hiding this comment.
if the GasPrice is nil and GasLimit is 0 then what happens to the transaction once it gets sent? Not really clear what is the expected behavior here?
There was a problem hiding this comment.
those are the values for the transaction request, not the transaction itself. gas price nil means the transaction service will query the ethereum node for a gas price, gas limit 0 means it will do a gas estimation.
There was a problem hiding this comment.
cool. maybe good to document this inline?
ralph-pichler
force-pushed
the
erc20_no_bindings
branch
from
97afd5a to
bc94d18
Compare
|
/run beekeeper |
this is the third in a series of PRs which remove the use of abigen-generated bindings in favour of just using the few things we need directly building on top of #1361.
This PR
storage-incentiveswhere some code is currently duplicated)