Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug api as a concrete service #1370

Merged
merged 1 commit into from
Mar 4, 2021
Merged

debug api as a concrete service #1370

merged 1 commit into from
Mar 4, 2021

Conversation

janos
Copy link
Member

@janos janos commented Mar 2, 2021

This PR is a followup on #1358 comments on code improvements.

  • interface is removed for simplification as its purpose is not justified with the complex method that it contains
  • server struct is renamed to Service and all fields are unexported
  • cors headers handling is contained into one file with a dedicated handler
  • basic tests for cors headers are added

@janos janos added the ready for review The PR is ready to be reviewed label Mar 2, 2021
@janos janos requested review from acud and metacertain March 2, 2021 21:32
@janos janos self-assigned this Mar 2, 2021
acud
acud approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@janos janos merged commit e043c29 into master Mar 4, 2021
@janos janos deleted the debugapi-concrete-service branch March 4, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acud acud acud approved these changes

@ralph-pichler ralph-pichler ralph-pichler approved these changes

@metacertain metacertain Awaiting requested review from metacertain

Assignees

@janos janos

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janos @ralph-pichler @acud