chequebook: change cashout api to include uncashed amount #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-pichler
force-pushed
the
uncashed_amount
branch
from
82897b6 to
9ce168a
Compare
zelig
approved these changes
Mar 9, 2021
|
@zelig swap just translates from peer to chequebook and forwards the reference to the cashout status struct, so there was no change necessary there. |
acud
approved these changes
Mar 16, 2021
| var action *cashoutAction | ||
| err := s.store.Get(cashoutActionKey(chequebookAddress), &action) | ||
| err = s.store.Get(cashoutActionKey(chequebookAddress), &action) |
There was a problem hiding this comment.
consider initializing action as an instance, then just pass the address here
ralph-pichler
force-pushed
the
uncashed_amount
branch
from
c423a39 to
a8878a0
Compare
ralph-pichler
force-pushed
the
uncashed_amount
branch
from
a8878a0 to
8679e0e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the GET cashout endpoint to include uncashed amount. it always returns uncashed amount even if no cashout has taken place so far (as long as we have in fact at least one cheque from the peer).
The main advantage of putting this into cashout endpoint are easier cashout scripts as we can all relevant values in one call and better handling of currently pending or cancelled transactions (in the calculation of uncashed amount).
This is an API-breaking change as in addition to the new
uncashedAmount, several values moved intolastCashedCheque(which may benull).