Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction: add extra gas everywhere #1487

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Mar 24, 2021

add an extra 20% gas to all transactions if the estimator is used.

deployment transactions can also run out of gas if multiple chequebooks are deployed in the same block.

@ralph-pichler ralph-pichler self-assigned this Mar 24, 2021
@ralph-pichler ralph-pichler marked this pull request as ready for review March 24, 2021 20:10
@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Mar 24, 2021
Copy link
Collaborator

@ldeffenb ldeffenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Granted this uses Integer math, but wouldn't gasLimit *= 1.2 be more readable?

@ralph-pichler
Copy link
Member Author

@ldeffenb more readable sure, but not compilable. an alternative would be gasLimit = (gasLimit * 120) / 100.

@ralph-pichler
Copy link
Member Author

/run beekeeper

Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ralph-pichler ralph-pichler merged commit 5be8761 into master Mar 29, 2021
@ralph-pichler ralph-pichler deleted the gas_limit_extra branch March 29, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants