Removing collections package and API cleanup #1501
Conversation
aloknerurkar
force-pushed
the
feat/apiCleanup.1
branch
from
4c51bd1 to
e19bd3b
Compare
aloknerurkar
changed the title
aloknerurkar
force-pushed
the
feat/apiCleanup.1
branch
from
62f37ed to
cb76b2d
Compare
Yes we can technically remove it now itself. It was listed as a separate work item, so was not sure if there is anything else we need to do. Beekeeper tests need to change. Will be looking into that now. |
pkg/api/bzz_test.go
Outdated
| http.StatusBadRequest, | ||
| jsonhttptest.WithRequestBody(bytes.NewReader(simpleData)), | ||
| jsonhttptest.WithExpectedJSONResponse(jsonhttp.StatusResponse{ | ||
| Message: "invalid content-type header", |
There was a problem hiding this comment.
the pattern we usually use is to define the error as a package variable (unexported), then export it using export_test, then check for the exact error which is exported in the `export_test_ file in the tests, instead of checking for the hardcoded text value (this allows to change the error messages later on quite easily)
There was a problem hiding this comment.
I went down a rabbit hole here. There are too many. I tried to do everything in the bzz/dirs files.
| jsonhttptest.WithExpectedResponse([]byte(expectedResponse)), | ||
| ) | ||
| } | ||
|
|
||
| validateBzzPath := func(t *testing.T, fromPath, toPath string) { | ||
| validateAltPath := func(t *testing.T, fromPath, toPath string) { |
There was a problem hiding this comment.
do we need the rename? I think valdiateBzzPath captures it no?
There was a problem hiding this comment.
This function validates that the file served on both the 'fromPath' and 'toPath' is the same (for redirects).
I named it 'AltPath' for 'alternate path'. I think this is better no?
File upload handler. New header for collections. Fixing tests. Adding new tests. Open API changes.
aloknerurkar
force-pushed
the
feat/apiCleanup.1
branch
from
20fa031 to
9c57250
Compare
#1444 #1543