Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default factory and add support for legacy factories #1539

Merged
merged 1 commit into from
May 17, 2021
Merged

update default factory and add support for legacy factories #1539

merged 1 commit into from
May 17, 2021

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Apr 6, 2021 •
edited by acud
Loading

  • updates the expected factory contract to the new version (with proxy-based and create2 deployments)
  • adds support for legacy factories from which we still accept chequebooks
  • adds recipient to abi call mock for better testing

This change is Reviewable

@ralph-pichler ralph-pichler self-assigned this Apr 6, 2021
@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Apr 6, 2021
acud
acud approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from no_bindings_at_all to master April 7, 2021 11:50
zelig
zelig approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wish we could eliminate the common package

@ralph-pichler ralph-pichler force-pushed the multi_factory branch 3 times, most recently from 68dc82b to 58cb9f2 Compare May 16, 2021 19:12
@ralph-pichler ralph-pichler mentioned this pull request May 17, 2021
Merged
@ralph-pichler ralph-pichler force-pushed the multi_factory branch 2 times, most recently from 15132c6 to ccabd98 Compare May 17, 2021 10:13
@ralph-pichler ralph-pichler merged commit 5a01238 into master May 17, 2021
@ralph-pichler ralph-pichler deleted the multi_factory branch May 17, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acud acud acud approved these changes

@zelig zelig zelig approved these changes

Assignees

@ralph-pichler ralph-pichler

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralph-pichler @zelig @acud