Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kademlia: add unsaturated bins to depth calculation #1553

Merged
merged 2 commits into from
Apr 13, 2021
Merged

kademlia: add unsaturated bins to depth calculation #1553

merged 2 commits into from
Apr 13, 2021

Conversation

acud
Copy link
Member

@acud acud commented Apr 7, 2021 •
edited
Loading

This PR adds unsaturated bins when calculating kademlia depth
Addresses #1418

@acud acud added the in progress ongoing development , hold out with review label Apr 7, 2021
@acud acud self-assigned this Apr 7, 2021
@acud acud force-pushed the kad-depth-unsaturated branch from a4fbaae to 8a19023 Compare April 8, 2021 06:46
@acud acud added ready for review The PR is ready to be reviewed and removed in progress ongoing development , hold out with review labels Apr 8, 2021
@acud acud requested review from zelig, istae and metacertain April 9, 2021 06:58
@acud acud changed the title kademlia: add unsaturated bins to depth calculation step kademlia: add unsaturated bins to depth calculation Apr 9, 2021
zelig
zelig requested changes Apr 9, 2021
View reviewed changes
pkg/kademlia/kademlia.go Outdated Show resolved Hide resolved
pkg/kademlia/kademlia.go Outdated Show resolved Hide resolved
@acud acud requested a review from zelig April 9, 2021 09:24
metacertain
metacertain approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@metacertain metacertain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@acud acud merged commit 78aba90 into master Apr 13, 2021
@acud acud deleted the kad-depth-unsaturated branch April 13, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacertain metacertain metacertain approved these changes

@zelig zelig zelig approved these changes

@istae istae Awaiting requested review from istae

Assignees

@acud acud

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acud @zelig @metacertain